Add PHPStan #672
Merged
Add PHPStan #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkobrenters
approved these changes
Feb 26, 2025
Collaborator
|
Love this first step to stricter code. |
Member
|
@DannyvdSluijs You've done some great work in the past days/weeks, thanks! Tried to merge, resolved conflicts, but ran into some issues. Could you check them? Did the merge based on your work in the previous PR's I just merged. |
Contributor
Author
|
@stephangroen thanks for merging all those PR's. I've pushed a fix. This was caused from changes from main being merged in, mostly because some issues from the baseline where already resolved in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces PHPStan and improves the source based on PHPStan findings. It also includes a GitHub action workflow to run the static analysis on every pull request making sure we won't introduce regression in future PR's. If an exception is needed the
phpstan-baseline.neoncan be regenerated. In this way there is a way around if the static analysis step would block a PR.I see this as a first set of improvements to make the exact-php-client more type safe and "free from bugs" both promises PHPStan is being used by in the PHP industry standards. Follow-up PR's could consist of
phpstan-baseline.neon, work is in progress in Upgrade phpunit #668 (Guzzle Response namespace was corrected in tests) as well as upstream in Improvements based on phpstan feedback downstream DannyvdSluijs/PicqerExactPhpClientGenerator#2 where results from running PHPStan in this library have been used to correct the code generating the models here.